On Wed, Jul 13, 2011 at 05:47:37PM +0900, Kukjin Kim wrote: > -static inline bool s3c_dma_has_circular(void) > +static inline bool dma_has_circular(void) > { > return false; > } The namespacing here doesn't look great, this is still a Samsung specific internal API. Otherwise this looks good.