[PATCH] ARM: OMAP4: PCM049: remove vusim regulator

Felipe Balbi balbi at ti.com
Fri Jul 15 03:58:26 EDT 2011


Hi,

On Fri, Jul 15, 2011 at 12:50:24AM -0700, Tony Lindgren wrote:
> * Jan Weitzel <J.Weitzel at phytec.de> [110714 01:34]:
> > Am Donnerstag, den 14.07.2011, 00:34 -0700 schrieb Tony Lindgren:
> > > * Jan Weitzel <J.Weitzel at phytec.de> [110713 05:51]:
> > > > Am Mittwoch, den 13.07.2011, 16:13 +0400 schrieb Sergei Shtylyov:
> > > > 
> > > > > 
> > > > >     Have you added that 'i' at the end intentionally?
> > > > > 
> > > > Thank you. It was a tribute to vim.
> > > 
> > > :i)
> > > 
> > > I'll fold the fixed patch into your original patch. Will also
> > > keep the new board files in testing-board because of the code
> > > coalescing and device tree conversion effort.
> > 
> > So there is no way to get the board mainline yet?
> 
> Well we can add it even before device tree support if it makes
> sense from code coalescing point of view. In this case it would
> mean creating board-panda-common.c or similar so the code can
> be shared amongst the panda variants.
> 
> It seems that some GPIO pins are different and there are some
> difference in devices connected, but big parts of the code can be
> shared.

isn't it easier than to just add a few if (machine_is_xxxx()) checks and
another MACHINE_START() to board-omap4panda.c rather than creating a new
file, shuffling code around and then adding a new board file ??

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110715/125881cc/attachment-0001.sig>


More information about the linux-arm-kernel mailing list