[PATCH v2 1/7] spi/imx: do not make copy of spi_imx_devtype_data
LW at KARO-electronics.de
Mon Jul 11 03:32:32 EDT 2011
Shawn Guo writes:
> On Mon, Jul 11, 2011 at 09:15:34AM +0200, Lothar Waßmann wrote:
> > Hi,
> > Shawn Guo writes:
> > > spi_imx_devtype_data has already been driver private data. There is
> > > really no need to make a copy in spi_imx_data. Instead, a reference
> > > pointer works perfectly fine.
> > >
> > You obviously overlooked, that the copy is done on purpose to keep
> > only the data that is actually needed and discard everything else
> > after initialisation.
> I did not overlook that, as I removed __devinitdata there.
But now you keep the whole array of which only one entry is being
used instead of only the used entry.
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info at karo-electronics.de
More information about the linux-arm-kernel