[PATCH v2 1/7] spi/imx: do not make copy of spi_imx_devtype_data
shawn.guo at freescale.com
Mon Jul 11 03:35:25 EDT 2011
On Mon, Jul 11, 2011 at 09:15:34AM +0200, Lothar Waßmann wrote:
> Shawn Guo writes:
> > spi_imx_devtype_data has already been driver private data. There is
> > really no need to make a copy in spi_imx_data. Instead, a reference
> > pointer works perfectly fine.
> You obviously overlooked, that the copy is done on purpose to keep
> only the data that is actually needed and discard everything else
> after initialisation.
I did not overlook that, as I removed __devinitdata there.
More information about the linux-arm-kernel