[PATCH v4 3/7] OMAP2+: PM: Initialise sleep_switch to a non-valid value

Kevin Hilman khilman at ti.com
Fri Jul 8 10:19:32 EDT 2011


Paul Walmsley <paul at pwsan.com> writes:

> cc'ing Kevin, since this touches mach-omap2/pm.c - an ack would be great 
> if you have the chance
>
> On Fri, 1 Jul 2011, Benoit Cousson wrote:
>
>> From: Rajendra Nayak <rnayak at ti.com>
>> 
>> sleep_switch which is initialised to 0 in omap_set_pwrdm_state
>> happens to be a valid sleep_switch type (FORCEWAKEUP_SWITCH)
>> which are defined as:
>> 
>>  #define FORCEWAKEUP_SWITCH      0
>>  #define LOWPOWERSTATE_SWITCH    1
>> 
>> This causes the function to wrongly program some clock domains
>> even when the Powerdomain is in ON state.
>> 
>> Signed-off-by: Rajendra Nayak <rnayak at ti.com>
>> Cc: Paul Walmsley <paul at pwsan.com>


Acked-by: Kevin Hilman <khilman at ti.com>


>
> Thanks, this patch has been queued for 3.1 at 
> git://git.pwsan.com/linux-2.6 in the 'powerdomain_fixes_3.1' branch.
>
>
> - Paul



More information about the linux-arm-kernel mailing list