[PATCH 16/17] mc13xxx: mfd_cell is now implicitly available to drivers

Fabio Estevam festevam at gmail.com
Thu Feb 17 06:53:56 EST 2011


Hi Uwe,

2011/2/16 Uwe Kleine-König <u.kleine-koenig at pengutronix.de>:
> On Wed, Feb 16, 2011 at 10:31:10AM -0200, Fabio Estevam wrote:
>> Hi Uwe,
>>
>> On 2/16/2011 7:41 AM, Uwe Kleine-König wrote:
>> ...
>> >>  /* MC13783 */
>> >> -static struct mc13783_platform_data mc13783_pdata __initdata = {
>> > isn't using __initdata here broken already before your patch?  Was
>> > introduced in c67a3e09.  Fabio?
>>
>> I followed the same approach as in mx31_3ds.c file.
>>
>> > But in general I'd prefer to keep as much __initdata as possible because
>> > this occupies less memory when using a multi-machine kernel.
>>
>> Ok, is the __initdata usage correct then? If not, I can change it. Just let me know.
> I guess that if you compile mc13xxx support as module it won't work.
>
> Try that, and if it breaks, send a patch fixing mx31_3ds.c, too.

I built it as module and the build went fine.

Regards,

Fabio Estevam



More information about the linux-arm-kernel mailing list