[PATCH 16/17] mc13xxx: mfd_cell is now implicitly available to drivers

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Wed Feb 16 07:58:20 EST 2011


On Wed, Feb 16, 2011 at 10:31:10AM -0200, Fabio Estevam wrote:
> Hi Uwe,
> 
> On 2/16/2011 7:41 AM, Uwe Kleine-König wrote:
> ... 
> >>  /* MC13783 */
> >> -static struct mc13783_platform_data mc13783_pdata __initdata = {
> > isn't using __initdata here broken already before your patch?  Was
> > introduced in c67a3e09.  Fabio?
> 
> I followed the same approach as in mx31_3ds.c file.
>  
> > But in general I'd prefer to keep as much __initdata as possible because
> > this occupies less memory when using a multi-machine kernel.
> 
> Ok, is the __initdata usage correct then? If not, I can change it. Just let me know.
I guess that if you compile mc13xxx support as module it won't work.

Try that, and if it breaks, send a patch fixing mx31_3ds.c, too.

Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list