[PATCH v3 2/2] ARM: SMP: Refactor Kconfig to be more maintainable

Dave Martin dave.martin at linaro.org
Mon Dec 12 11:40:06 EST 2011


On Mon, Dec 12, 2011 at 03:59:12PM +0000, Russell King - ARM Linux wrote:
> On Mon, Dec 12, 2011 at 03:04:05PM +0000, Dave Martin wrote:

[...]

> > Duh.  Sorry about that -- will fix and repost.
> > 
> > 
> > Do you have a preference about where to insert new items where the list
> > is not already in alphabetical order?
> 
> What I've done in the past is roughly to ignore anything which isn't
> alphabetical from the top, and place it within that subset.  I
> simetimes change that (if there's a group of HAVE_xxx which is already
> sorted, I add it within that sub-group.)
> 
> In other words, try to sensibly place it so the addition itself is
> alphabetically between two other options which are already so sorted.

OK; I've attempted to do this where I can.

Where it's possible to chop a jumbled list somewhere in the middle such
that the added option sorts strictly after everything in the first
chunk and strictly before everything in the second chunk, I've done that,
so:

	A
	G
	F
+	I
	Z
	P
	W

...which I believe satisfies your criterion.

Where this is not possible, I ignore the smallest amount of items
possible at either end of the list such that the above works, so in:

	A
	G
	F
+	I
	Z
	P
	W
	H
	Z

... I ignore the final H and Z.  The only way to be in order with
respect to those would be to put I far away from its correct position,
which would be undesirable.

This stragety should mean that nothing ever needs to move across the
newly added item, unless the list is already significantly out of order
(in which case there's no perfect solution except for sorting the list).

Cheers
---Dave



More information about the linux-arm-kernel mailing list