[PATCH v3 2/2] ARM: SMP: Refactor Kconfig to be more maintainable

Russell King - ARM Linux linux at arm.linux.org.uk
Mon Dec 12 10:59:12 EST 2011


On Mon, Dec 12, 2011 at 03:04:05PM +0000, Dave Martin wrote:
> On Mon, Dec 12, 2011 at 02:10:01PM +0000, Russell King - ARM Linux wrote:
> > On Mon, Dec 12, 2011 at 11:47:06AM +0000, Dave Martin wrote:
> > > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> > > index 4234937..4aa7f7e 100644
> > > --- a/arch/arm/mach-imx/Kconfig
> > > +++ b/arch/arm/mach-imx/Kconfig
> > > @@ -611,6 +611,7 @@ config SOC_IMX6Q
> > >  	select ARM_GIC
> > >  	select CPU_V7
> > >  	select HAVE_ARM_SCU
> > > +	select HAVE_SMP
> > >  	select HAVE_IMX_GPC
> > >  	select HAVE_IMX_MMDC
> > >  	select HAVE_IMX_SRC
> > 
> > NAK.  I'll let you work out why.  It has something to do with ABCDEFGH...
> 
> Duh.  Sorry about that -- will fix and repost.
> 
> 
> Do you have a preference about where to insert new items where the list
> is not already in alphabetical order?

What I've done in the past is roughly to ignore anything which isn't
alphabetical from the top, and place it within that subset.  I
simetimes change that (if there's a group of HAVE_xxx which is already
sorted, I add it within that sub-group.)

In other words, try to sensibly place it so the addition itself is
alphabetically between two other options which are already so sorted.



More information about the linux-arm-kernel mailing list