[PATCH v2 23/23] at91: Remove mAgic and ISI device code

Russell King - ARM Linux linux at arm.linux.org.uk
Thu Apr 28 05:19:19 EDT 2011


On Fri, Apr 22, 2011 at 08:12:53AM +1200, Ryan Mallon wrote:
> On 22/04/11 05:33, H Hartley Sweeten wrote:
> > On Wednesday, April 20, 2011 10:42 PM, Ryan Mallon wrote:
> >>
> >> The AT572D940HF mAgic device and the AT91SAM9263 ISI device do not
> >> have drivers yet and therefore the platform code in arch/arm/mach-at91
> >> is unused and can be removed.
> > 
> > Is anyone planning on adding these drivers?
> > 
> > I wonder if it makes sense to add the infrastructure to devices.[ch] and
> > convert the users even it the drivers are not in mainline yet?
> 
> I removed them because there is currently a push to reduce the size of
> the ARM tree. The ISI code has been there since 2008 and the mAgic
> device code since 2009 without drivers. The ISI device at least is
> supported on more than one variant, but only had code present for the
> AT91SAM9263.

If they've not been merged for two to three years, they probably aren't
going to ever be merged.  Removing them seems to be the right thing to
do as they're not doing *anything* useful by remaining there.

They should be kept as part of the patch series adding the drivers.



More information about the linux-arm-kernel mailing list