[PATCH v2 23/23] at91: Remove mAgic and ISI device code

[Ryan Mallon]

On 04/26/2011 04:39 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 08:12 Fri 22 Apr     , Ryan Mallon wrote:
>> On 22/04/11 05:33, H Hartley Sweeten wrote:
>>> On Wednesday, April 20, 2011 10:42 PM, Ryan Mallon wrote:
>>>>
>>>> The AT572D940HF mAgic device and the AT91SAM9263 ISI device do not
>>>> have drivers yet and therefore the platform code in arch/arm/mach-at91
>>>> is unused and can be removed.
>>>
>>> Is anyone planning on adding these drivers?
>>>
>>> I wonder if it makes sense to add the infrastructure to devices.[ch] and
>>> convert the users even it the drivers are not in mainline yet?
>>
>> I removed them because there is currently a push to reduce the size of
>> the ARM tree. The ISI code has been there since 2008 and the mAgic
>> device code since 2009 without drivers. The ISI device at least is
>> supported on more than one variant, but only had code present for the
>> AT91SAM9263.
>>
>> I think it is better to remove them now, and then if/when drivers get
>> added the support code can be added to the common framework.
> NACK I do not want to remove code just to reduce line code for soc
> 
> factorize ok
> remove soc resources no
> 
> for the ISI I plan to add it but I work on something else by now
> 
> and some patch have already been send to the v4l ML

I'm fine with keeping them if there is driver support, but they do need
to be moved into the common framework. However I don't think it is worth
keeping dead code just be a driver _might_ appear. The mAgic code has
been sitting in the the kernel for over two years with no users.
Especially with the current push to reduce the size of the ARM tree, it
needs to go.

~Ryan

-- 
Bluewater Systems Ltd - ARM Technology Solution Centre

Ryan Mallon         		5 Amuri Park, 404 Barbadoes St
ryan at bluewatersys.com         	PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com	New Zealand
Phone: +64 3 3779127		Freecall: Australia 1800 148 751
Fax:   +64 3 3779135			  USA 1800 261 2934