[PATCH 5/5] driver core: let dev_set_drvdata return int instead of void as it can fail
u.kleine-koenig at pengutronix.de
Wed Apr 6 07:06:23 EDT 2011
On Wed, Apr 06, 2011 at 11:36:46AM +0200, Michał Mirosław wrote:
> 2011/4/6 Uwe Kleine-König <u.kleine-koenig at pengutronix.de>:
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> > ---
> > Hello,
> > I wasn't sure what to return when dev_set_drvdata is called with
> > dev=NULL. I choosed 0, but -EINVAL would be OK for me, too. What do you
> > think?
> Why not just BUG_ON(!dev)? Is there a case when you might call this
> with dev==NULL that's not a driver bug?
I think BUG_ON is too harsh. Will resend with -EINVAL.
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
More information about the linux-arm-kernel