[PATCH 5/5] driver core: let dev_set_drvdata return int instead of void as it can fail

Michał Mirosław mirqus at gmail.com
Wed Apr 6 05:36:46 EDT 2011

2011/4/6 Uwe Kleine-König <u.kleine-koenig at pengutronix.de>:
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
> Hello,
> I wasn't sure what to return when dev_set_drvdata is called with
> dev=NULL.  I choosed 0, but -EINVAL would be OK for me, too. What do you
> think?

Why not just BUG_ON(!dev)? Is there a case when you might call this
with dev==NULL that's not a driver bug?

Best Regards,
Michał Mirosław

More information about the linux-arm-kernel mailing list