[PATCH 03/74] ST SPEAr: Formalized timer support

Russell King - ARM Linux linux at arm.linux.org.uk
Mon Sep 13 03:49:38 EDT 2010


On Mon, Sep 13, 2010 at 08:52:49AM +0530, Shiraz Hashim wrote:
> Dear Jean,
> 
> On 9/7/2010 4:25 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> >>  
> >> -#endif
> >> +static void __init spear3xx_timer_init(void)
> >> +{
> >> +	spear_setup_timer();
> > why not call it directly?
> 
> A single level of abstraction was provided so that if archs (spear3xx/6xx/13xx)
> required to do something extra.

Please don't build abstraction layers on top of abstraction layers.  Use
what's already provided instead.



More information about the linux-arm-kernel mailing list