[spi-devel-general] [PATCH] SPI: fix APB pclk power regression on U300

Grant Likely grant.likely at secretlab.ca
Wed Sep 8 14:24:54 EDT 2010


On Mon, Aug 23, 2010 at 10:30:17AM -0700, Kevin Wells wrote:
> > With the introduction of an AMBA PrimeCell per-cell block clock,
> > the pclk was left on after probe() unless explicitly disabled.
> > This clock is wired to the same clock on PL022 causing it to stay
> > always on since.
> >
> > Fix this up properly by clocking the pclk whenever we want to
> > write into any PL022 registers and clocking the external clock
> > whenever we want to transmit messages on the bus.
> >
> > Signed-off-by: Linus Walleij <linus.walleij at stericsson.com>
> > ---
> > Tested on U300 and U8500, even though the pclk stuff came in from
> > the ARM tree it is probably better to carry this through Grants
> > tree so as not to disturb other patches going in for PL022.
> > ---
> >  drivers/spi/amba-pl022.c |   14 ++++++++------
> >  1 files changed, 8 insertions(+), 6 deletions(-)
> >
> 
> Tested-by : Kevin Wells <wellsk40 at gmail.com>

Applied, thanks.

g.



More information about the linux-arm-kernel mailing list