[PATCH] ARM: PL330: Accept revisions of the dmac

Jassi Brar jassisinghbrar at gmail.com
Sun Sep 5 05:53:22 EDT 2010


On Sun, Sep 5, 2010 at 6:14 PM, Linus Walleij
<linus.ml.walleij at gmail.com> wrote:
> 2010/9/3 Jassi Brar <jassisinghbrar at gmail.com>:
>
>> -#define PERIPH_ID_VAL  ((PART << 0) | (DESIGNER << 12) \
>> -                         | (REVISION << 20) | (INTEG_CFG << 24))
>> +#define PERIPH_ID_VAL  ((PART << 0) | (DESIGNER << 12))
>>
>>  #define PCELL_ID_VAL   0xb105f00d
>
> Jassi, this kind of macros already exist in <linux/amba/bus.h>
> can't you just #include that and use these instead?
You mean to use amba_config/rev et al ?
But they work on struct amba_device *, and I have to form those
structs just to make use of the macros. How useful would that be?
Or I got you wrong?
Thanks.



More information about the linux-arm-kernel mailing list