[PATCH] ARM: PL330: Accept revisions of the dmac

Linus Walleij linus.ml.walleij at gmail.com
Sun Sep 5 05:14:37 EDT 2010


2010/9/3 Jassi Brar <jassisinghbrar at gmail.com>:

> -#define PERIPH_ID_VAL  ((PART << 0) | (DESIGNER << 12) \
> -                         | (REVISION << 20) | (INTEG_CFG << 24))
> +#define PERIPH_ID_VAL  ((PART << 0) | (DESIGNER << 12))
>
>  #define PCELL_ID_VAL   0xb105f00d

Jassi, this kind of macros already exist in <linux/amba/bus.h>
can't you just #include that and use these instead?

Notice that you have the ID encoded in drivers/dma/pl330.c as
well so can you also update the mask/add a few ID:s to
pl330_ids[] in that file when you change this?

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list