[PATCH] ARM: orion5x/kirkwood/mv78xx0: fix MPP configuration corner cases
ben-linux at fluff.org
Sat Oct 30 18:18:52 EDT 2010
On 29/10/10 05:12, Nicolas Pitre wrote:
> On Sun, 24 Oct 2010, Mike Rapoport wrote:
>> Wrong MPP configuration would cause <cpu>_mpp_conf loop infinitely
>> because the mpp list iterator would not be incremented.
>> Signed-off-by: Mike Rapoport <mike at compulab.co.il>
>> arch/arm/mach-kirkwood/mpp.c | 5 +++--
>> arch/arm/mach-mv78xx0/mpp.c | 5 +++--
>> arch/arm/mach-orion5x/mpp.c | 5 +++--
>> 3 files changed, 9 insertions(+), 6 deletions(-)
> Instead of adding gotos, could you simply replace the
> "while (*mpp_list)" loop with "for ( ; *mpp_list; mpp_list++)" ?
you'd have to remove the mpp_list++, but this would be in my
view a nicer solution avoiding gotos and any re-occurence of
this in the future.
More information about the linux-arm-kernel