[PATCH] ARM: orion5x/kirkwood/mv78xx0: fix MPP configuration corner cases
Nicolas Pitre
nico at fluxnic.net
Fri Oct 29 00:12:14 EDT 2010
On Sun, 24 Oct 2010, Mike Rapoport wrote:
> Wrong MPP configuration would cause <cpu>_mpp_conf loop infinitely
> because the mpp list iterator would not be incremented.
>
> Signed-off-by: Mike Rapoport <mike at compulab.co.il>
> ---
> arch/arm/mach-kirkwood/mpp.c | 5 +++--
> arch/arm/mach-mv78xx0/mpp.c | 5 +++--
> arch/arm/mach-orion5x/mpp.c | 5 +++--
> 3 files changed, 9 insertions(+), 6 deletions(-)
[...]
Instead of adding gotos, could you simply replace the
"while (*mpp_list)" loop with "for ( ; *mpp_list; mpp_list++)" ?
Nicolas
More information about the linux-arm-kernel
mailing list