[PATCH] msm: fix debug-macro.S build failure
Nicolas Pitre
nico at fluxnic.net
Thu Oct 28 14:40:19 EDT 2010
On Thu, 28 Oct 2010, Daniel Walker wrote:
> On Thu, 2010-10-28 at 14:24 -0400, Nicolas Pitre wrote:
> > On Thu, 28 Oct 2010, Daniel Walker wrote:
> >
> > > This is what the function currently has,
> > >
> > > .macro addruart, rp, rv
> > > ldr \rp, =MSM_DEBUG_UART_PHYS
> > > ldr \rv, =MSM_DEBUG_UART_BASE
> > > .endm
> > >
> > > So if we have a MSM_DEBUG_UART_PHYS and MSM_DEBUG_UART_BASE we're
> > > returning it. We don't actually have those values for all the boards
> > > tho. My understanding was that there are some generic arm changes
> > > needed, but I need to confirm that.
> >
> > Just return 0 in both registers when you have nothing better to return.
>
> What about the other functions ?
We can test for rv == 0 and bail out early with a "mov pc, lr".
Nicolas
More information about the linux-arm-kernel
mailing list