[PATCH] msm: fix debug-macro.S build failure
Russell King - ARM Linux
linux at arm.linux.org.uk
Thu Oct 28 14:28:51 EDT 2010
On Thu, Oct 28, 2010 at 02:24:33PM -0400, Nicolas Pitre wrote:
> On Thu, 28 Oct 2010, Daniel Walker wrote:
> > This is what the function currently has,
> > .macro addruart, rp, rv
> > ldr \rp, =MSM_DEBUG_UART_PHYS
> > ldr \rv, =MSM_DEBUG_UART_BASE
> > .endm
> > So if we have a MSM_DEBUG_UART_PHYS and MSM_DEBUG_UART_BASE we're
> > returning it. We don't actually have those values for all the boards
> > tho. My understanding was that there are some generic arm changes
> > needed, but I need to confirm that.
> Just return 0 in both registers when you have nothing better to return.
That's not a good idea - it'll cause 512MB of 1:1 mappings to be setup
at virtual location 0 using the IO flags, which may conflict on ARMv6+.
A better idea would be to return 0xfff00000, which'll cause it to only
populate the top-most 1MB.
More information about the linux-arm-kernel