[PATCH] msm: fix debug-macro.S build failure
dwalker at codeaurora.org
Thu Oct 28 12:30:13 EDT 2010
On Wed, 2010-10-27 at 22:30 -0400, Nicolas Pitre wrote:
> On Wed, 27 Oct 2010, Russell King - ARM Linux wrote:
> > > +#else
> > > + .macro addruart, rx, tmp
> > addruart is now expected to return two values, and 'tmp' ends up being
> > misleading. This is a recipe for mistakes unless this is corrected.
> > It should be 'rp, rv' instead of 'rx, tmp'.
> Also, it is probably not a good idea to return nothing. Otherwise the
> code using those macros will then work on random values that just
> happened to be in the corresponding register at the call location.
Should we have something in generic arm code that allows this to just be
turned off? Ideally we don't want any of this stuff even running.
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
More information about the linux-arm-kernel