[PATCH] msm: fix debug-macro.S build failure

Nicolas Pitre nico at fluxnic.net
Wed Oct 27 22:30:36 EDT 2010

On Wed, 27 Oct 2010, Russell King - ARM Linux wrote:

> > +#else
> > +	.macro	addruart, rx, tmp
> addruart is now expected to return two values, and 'tmp' ends up being
> misleading.  This is a recipe for mistakes unless this is corrected.
> It should be 'rp, rv' instead of 'rx, tmp'.

Also, it is probably not a good idea to return nothing. Otherwise the 
code using those macros will then work on random values that just 
happened to be in the corresponding register at the call location.


More information about the linux-arm-kernel mailing list