QNAP TS-209 broken by "orion/kirkwood: reset PCIe unit on boot"
nico at fluxnic.net
Thu Oct 21 16:25:05 EDT 2010
On Thu, 21 Oct 2010, Saeed Bishara wrote:
> >> I noticed that 2.6.36-rc no longer boots on my QNAP TS-209. I get
> >> some output but then the machine resets.
> >> I've bisected it down to the patch "orion/kirkwood: reset PCIe unit on
> >> boot". I remember this patch was controversial when it was proposed.
> >> Looks like it breaks at least one orion5x machine. Maybe the patch
> >> should be reverted for now or only be called on kirkwood.
> >According to the log, you did agree with that patch at the time.
> >Keeping it causes breakage. Removing it causes breakage too. So I'd
> >much prefer if a solution to solve both breakages was merged instead.
> We couln't pinpoint the root cause of this issue, actually we failed to reproduce that issue.
> Nico, I suggest to apply the orion_pcie_reset() only for the boards we the issue had been observed.
OK, so I did, and pushed the result to the Orion git tree
Can I have confirmation that 1) new breakages are gone, and 2) the
device where this reset did fix problems are still OK with this change?
More information about the linux-arm-kernel