[PATCH 5/5] ARM: SAMSUNG: Add to enable/disable clock on S3C PL330

Kyungmin Park kmpark at infradead.org
Wed Oct 20 23:54:56 EDT 2010


On Thu, Oct 21, 2010 at 11:36 AM, Kukjin Kim <kgene.kim at samsung.com> wrote:
> Kyungmin Park wrote:
>>
>> On Thu, Oct 21, 2010 at 9:58 AM, Kukjin Kim <kgene.kim at samsung.com> wrote:
>> > From: Seungwhan Youn <sw.youn at samsung.com>
>> >
>> > This patch adds to enable/disable DMA operation clock on S3C-PL330
>> > DMA controller driver.
>>
>> The title and description seems to clock gating but actual code is
>> just enable at probe and disable at remove.
>>
>> Can you make it REAL clock gating, enable clock only when using?
>>
>
> This is just to move DMA enable/disable clock into DMA driver(S3C PL330).
> So it would be better if we could discuss about what you said next time.
>
> Basically, I prefer most clocks should be registered as disabled, then if
> required enable, just should be controlled in each driver.

And support clock & block gating basically at drivers.
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



More information about the linux-arm-kernel mailing list