[PATCH v2 1/1] mx35pdk: add debug board support

[xiao jiang]

2010/10/21 xiao jiang <jgq516 at gmail.com>

> Hi Baruch,
>
> 2010/10/20 Baruch Siach <baruch at tkos.co.il>
>
> Hi jgq516,
>>
>> On Wed, Oct 20, 2010 at 05:34:43PM +0800, jgq516 at gmail.com wrote:
>> > From: Xiao Jiang <jgq516 at gmail.com>
>> >
>> > Enable debug board support for mx35pdk. As suggested
>> > by Fabio, add MXC_DEBUG_BOARD config and redefinition
>> > EXPIO_PARENT_INT.
>> >
>> > Signed-off-by: Xiao Jiang <jgq516 at gmail.com>
>> > Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
>> > ---
>> >  arch/arm/mach-mx3/Kconfig         |    1 +
>> >  arch/arm/mach-mx3/mach-mx35_3ds.c |    8 ++++++++
>> >  2 files changed, 9 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/arch/arm/mach-mx3/Kconfig b/arch/arm/mach-mx3/Kconfig
>> > index 85beece..cdf6ac5 100644
>> > --- a/arch/arm/mach-mx3/Kconfig
>> > +++ b/arch/arm/mach-mx3/Kconfig
>>
>> [snip]
>>
>> > @@ -95,6 +99,10 @@ static void __init mxc_board_init(void)
>> >       imx35_add_imx_uart0(&uart_pdata);
>> >
>> >       mxc_register_device(&mxc_otg_udc_device, &usb_pdata);
>> > +
>> > +     if (mxc_expio_init(MX35_CS5_BASE_ADDR, EXPIO_PARENT_INT))
>> > +             pr_warn("Init of the debugboard failed, all "
>> > +                     "devices on the board are unusable.\n");
>>                             ^^^^^
>> You probably mean debugboard here. I'd change the wording.
>>
>> There are some devices in the debug board, such as lan9217 ethernet. If
> mxc_expio_init failed,
> then the lan9217 can't be use.
> BTW: In mach-mx5/board-mx51_3ds.c and mach-mx31_3ds.c, the warn messages
> are same.
> if (mxc_expio_init(MX51_CS5_BASE_ADDR,
> EXPIO_PARENT_INT))
>
>                  printk(KERN_WARNING "Init of the debugboard failed, all "
>
>                                      "devices on the board are
> unusable.\n");
>
> Ooo, I pressed  the keyboard neglectfully[?], and you can see below
sentence in mach-mx31_3ds.c.
if (!mxc_expio_init(CS5_BASE_ADDR, EXPIO_PARENT_INT))
         printk(KERN_WARNING "Init of the debugboard failed, all "
               "devices on the board are unusable.\n");

Thanks,
Xiao Jiang

> baruch
>>
>> --
>>                                                     ~. .~   Tk Open
>> Systems
>>
>> =}------------------------------------------------ooO--U--Ooo------------{=
>>   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101021/13e5fb59/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/png
Size: 630 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101021/13e5fb59/attachment-0001.png>