w1-gpio oops

[Arnaud Patard (Rtp)]

Alan Pearson <alandpearson at gmail.com> writes:

Hi,

>>> ----- Original Message ----- From: "Alan Pearson" <alandpearson at gmail.com>
>>> To: <linux-arm-kernel at lists.infradead.org>
>>> Sent: Tuesday, November 09, 2010 7:29 PM
>>> Subject: w1-gpio oops
>>> 
>>> 
>>>> Hi Guys,
>>>> 
>>>> First post to list, so be kind :)
>>>> 
>>>> I'm trying to get w1 (one wire) working over GPIO and despite my best efforts this results in a nasty oops.
>>>> Firstly, I'd like to say I'm no kernel hacker and my knowledge of Ooops and kernel debugging is limited, but I'm willing to learn:)
>>> 
>>> Common cause for these errors could be nonexistent or incorrect platform data. Might be worth checking if w1_gpio_platform_data
>>> is proper in your board file. You could look for examples in other board files like arch/arm/mach-pxa/raumfeld.c
>>> 
>> 
>> <CHOP>
>> 
>> Ok, I had understood the platform data was being set in the w1_gpio_custom module by the loadable options.
>> Is this not the case, or does it also need defined in the board file, which I presume is guruplug_setup.c ?
>> It's currently not defined there. But as I said I expected the other module to do this, am I wrong ?
>> 
>> 
>> Looking at the function w1_gpio_probe, it doesnot seem to be using module params. So u might need to define those
>> in your board file.
>> 
>
> OK, I've modified my board file like so (guruplug-setup.c) :
>
>
> static struct w1_gpio_platform_data guru_gpio_platform_data = {
>         .pin                    = MPP38_GPIO,

It's 38 not MPP38_GPIO. MPP38_GPIO is for the guruplug_mpp_config[]
stuff (looks at how the leds are configured for instance)


Arnaud