[PATCH 08/25] imx/mx1: rename files defining a machine to mach-$mach.c
Uwe Kleine-König
u.kleine-koenig at pengutronix.de
Thu Feb 4 03:45:13 EST 2010
Hello Amit,
On Wed, Feb 03, 2010 at 05:29:16PM -0800, Amit Kucheria wrote:
> On 10 Jan 08, Uwe Kleine-König wrote:
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> > Cc: Sascha Hauer <kernel at pengutronix.de>
> > Cc: Russell King <linux at arm.linux.org.uk>
> > Cc: Paulius Zaleckas <paulius.zaleckas at teltonika.lt>
> > Cc: Darius Augulis <augulis.darius at gmail.com>
> > Cc: Mauro Carvalho Chehab <mchehab at redhat.com>
> > ---
> > arch/arm/mach-mx1/Makefile | 4 ++--
> > arch/arm/mach-mx1/{mx1ads.c => mach-mx1ads.c} | 2 +-
> > arch/arm/mach-mx1/{scb9328.c => mach-scb9328.c} | 2 +-
> > 3 files changed, 4 insertions(+), 4 deletions(-)
> > rename arch/arm/mach-mx1/{mx1ads.c => mach-mx1ads.c} (98%)
> > rename arch/arm/mach-mx1/{scb9328.c => mach-scb9328.c} (98%)
>
> Rethinking about this (based on a similar request for my i.MX5 submission), I
> think renaming the boards to mach-* is a bad idea.
>
> Other SoCs (davinci, omap, msm, nomadik, etc.) use the board-* convention. We
> already use mach-* for the SoC directory names under arch/arm/. Naming the
> boards with mach-* will just cause more confusion.
Hmmm
I still prefer mach-* as the corresponding Kconfig variables are named
MACH_* and there is no unified meaning of "board". For (I think) most
people here board describes the whole machine. For some (e.g. me) a
board might only be a PCB where you have to plug in a module that comes
with the SoC.
(http://www.digi.com/products/model.jsp?lid=EN&pgid=37&pfid=19&mtid=2070&amtid=2070&pm=Y)
It think machine is precise for all of us.
And note the selecting Kconfig symbol for arch/arm/mach-omap is
ARCH_OMAP. Ditto we have ARCH_DAVINCI, ARCH_MSM and ARCH_NOMADIK.
So we could rename these to arch-omap etc. But then this conflicts with
the toplevel arch directory!?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
More information about the linux-arm-kernel
mailing list