[PATCH 08/25] imx/mx1: rename files defining a machine to mach-$mach.c

Amit Kucheria amit.kucheria at canonical.com
Wed Feb 3 20:29:16 EST 2010


On 10 Jan 08, Uwe Kleine-König wrote:
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> Cc: Sascha Hauer <kernel at pengutronix.de>
> Cc: Russell King <linux at arm.linux.org.uk>
> Cc: Paulius Zaleckas <paulius.zaleckas at teltonika.lt>
> Cc: Darius Augulis <augulis.darius at gmail.com>
> Cc: Mauro Carvalho Chehab <mchehab at redhat.com>
> ---
>  arch/arm/mach-mx1/Makefile                      |    4 ++--
>  arch/arm/mach-mx1/{mx1ads.c => mach-mx1ads.c}   |    2 +-
>  arch/arm/mach-mx1/{scb9328.c => mach-scb9328.c} |    2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
>  rename arch/arm/mach-mx1/{mx1ads.c => mach-mx1ads.c} (98%)
>  rename arch/arm/mach-mx1/{scb9328.c => mach-scb9328.c} (98%)

Rethinking about this (based on a similar request for my i.MX5 submission), I
think renaming the boards to mach-* is a bad idea.

Other SoCs (davinci, omap, msm, nomadik, etc.) use the board-* convention. We
already use mach-* for the SoC directory names under arch/arm/. Naming the
boards with mach-* will just cause more confusion.

Regards,
Amit


> diff --git a/arch/arm/mach-mx1/Makefile b/arch/arm/mach-mx1/Makefile
> index b72f536..297d172 100644
> --- a/arch/arm/mach-mx1/Makefile
> +++ b/arch/arm/mach-mx1/Makefile
> @@ -10,5 +10,5 @@ obj-y			+= generic.o clock.o devices.o
>  obj-$(CONFIG_MX1_VIDEO)	+= ksym_mx1.o mx1_camera_fiq.o
>  
>  # Specific board support
> -obj-$(CONFIG_ARCH_MX1ADS) += mx1ads.o
> -obj-$(CONFIG_MACH_SCB9328) += scb9328.o
> +obj-$(CONFIG_ARCH_MX1ADS) += mach-mx1ads.o
> +obj-$(CONFIG_MACH_SCB9328) += mach-scb9328.o
> diff --git a/arch/arm/mach-mx1/mx1ads.c b/arch/arm/mach-mx1/mach-mx1ads.c
> similarity index 98%
> rename from arch/arm/mach-mx1/mx1ads.c
> rename to arch/arm/mach-mx1/mach-mx1ads.c
> index 30f04e5..a39433a 100644
> --- a/arch/arm/mach-mx1/mx1ads.c
> +++ b/arch/arm/mach-mx1/mach-mx1ads.c
> @@ -1,5 +1,5 @@
>  /*
> - * arch/arm/mach-imx/mx1ads.c
> + * arch/arm/mach-imx/mach-mx1ads.c
>   *
>   * Initially based on:
>   *	linux-2.6.7-imx/arch/arm/mach-imx/scb9328.c
> diff --git a/arch/arm/mach-mx1/scb9328.c b/arch/arm/mach-mx1/mach-scb9328.c
> similarity index 98%
> rename from arch/arm/mach-mx1/scb9328.c
> rename to arch/arm/mach-mx1/mach-scb9328.c
> index 325d98d..b9530d7 100644
> --- a/arch/arm/mach-mx1/scb9328.c
> +++ b/arch/arm/mach-mx1/mach-scb9328.c
> @@ -1,5 +1,5 @@
>  /*
> - * linux/arch/arm/mach-mx1/scb9328.c
> + * linux/arch/arm/mach-mx1/mach-scb9328.c
>   *
>   * Copyright (c) 2004 Sascha Hauer <saschahauer at web.de>
>   * Copyright (c) 2006-2008 Juergen Beisert <jbeisert at netscape.net>
> -- 
> 1.6.5.2
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
-------------------------------------------------------------------------
Amit Kucheria,				 Kernel Developer, Verdurent
-------------------------------------------------------------------------



More information about the linux-arm-kernel mailing list