[PATCH 40/54] ARM: Samsung SoCs: irq_data conversion.
Kukjin Kim
kgene.kim at samsung.com
Fri Dec 17 00:40:21 EST 2010
Lennert Buytenhek wrote:
>
> On Fri, Dec 03, 2010 at 08:56:03PM +0900, Kukjin Kim wrote:
>
> > Hi Lennert,
>
> Hi again,
>
Hi :-)
>
> > (Added Mark Brown in Cc)
> >
> > Looks ok to me but there are some comments.
> >
> > Firstly, how about to separate this to regarding S3C24XX(mach-s3c24xx
and
> > plat-s3c24xx), S5P(mach-s5pxxxx and plat-s5p) and plat-samsung?
> > (Actually, already applied S3C64XX changes so that we can drop that in
your
> > patch.)
> >
> > As you know, I already applied some changes which is from Mark Brown in
my
> > tree.
> > You can find that in
> > git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
> > #for-next
> >
> > So could you please re-work this based on that?
>
> I've reworked the patch I had in my tree on top of your git tree
> (latest commit "Merge branch 'next-s5p64x0' into for-next"), and came
> up with the three attached patches. I've incorporated the whitespace
> changes you requested, and changed the struct irq_data * variable
> names from 'd' to 'data' to match Mark's earlier patches.
>
Ok...thanks.
> Caveat emptor -- uncompiled, and totally untested.
>
> How's this look?
>
Looks ok to me ;-)
> Feel free to merge this via your tree -- I'll drop the Samsung patch
> from my tree then.
>
Ok...will apply after some tests and if any problems, let you know.
Thanks again.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
More information about the linux-arm-kernel
mailing list