[PATCHv3] support PMIC mc13892

[Uwe Kleine-König]

Hi Mark,

On Wed, Dec 08, 2010 at 10:01:38AM +0000, Mark Brown wrote:
> On Wed, Dec 08, 2010 at 10:12:26AM +0100, Uwe Kleine-König wrote:
> 
> Please cut unneded context - it makes it much easier to find the new
> text in your replies!
hmm, well you could argue here.  The downside in this case you stripped
the err_alloc label that might be the right place to place my comment
here.  Sometimes I consider it hard what to strip but yes in general I
accede.
 
> > > +	if (ret)
> > > +		goto err_alloc;
> 
> > err_alloc seems wrong.  The goto is taken when reading the revision
> > register fails, not on a failed allocation.
> 
> His code is following the style of naming the exit points after what
> needs to be unwound rather than after the place jumped from which is
> common enough?
Then I'd prefer err_free.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |