[PATCHv3] support PMIC mc13892

[Mark Brown]

On Wed, Dec 08, 2010 at 10:12:26AM +0100, Uwe Kleine-König wrote:

Please cut unneded context - it makes it much easier to find the new
text in your replies!

> > +	if (ret)
> > +		goto err_alloc;

> err_alloc seems wrong.  The goto is taken when reading the revision
> register fails, not on a failed allocation.

His code is following the style of naming the exit points after what
needs to be unwound rather than after the place jumped from which is
common enough?

> > +#define MC13892_PWGT1SPI	21
> > +#define MC13892_PWGT2SPI	22
> > +#define MC13892_VCOINCELL	23

> I thought you wanted to put these somewhere below drivers/regulator/.

Please.