[PATCH 01/10] spi: amlogic-spifc-a1: Use FIELD_MODIFY()
Hans Zhang
18255117159 at 163.com
Thu Apr 30 08:54:47 PDT 2026
Use FIELD_MODIFY() to remove open-coded bit manipulation.
No functional change intended.
Signed-off-by: Hans Zhang <18255117159 at 163.com>
---
drivers/spi/spi-amlogic-spifc-a1.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-amlogic-spifc-a1.c b/drivers/spi/spi-amlogic-spifc-a1.c
index 7ee4c92e6e09..77a2c11bec5e 100644
--- a/drivers/spi/spi-amlogic-spifc-a1.c
+++ b/drivers/spi/spi-amlogic-spifc-a1.c
@@ -206,10 +206,9 @@ static int amlogic_spifc_a1_read(struct amlogic_spifc_a1 *spifc, void *buf,
u32 val = readl(spifc->base + SPIFC_A1_USER_CTRL3_REG);
int ret;
- val &= ~(SPIFC_A1_USER_DIN_MODE | SPIFC_A1_USER_DIN_BYTES);
val |= SPIFC_A1_USER_DIN_ENABLE;
- val |= FIELD_PREP(SPIFC_A1_USER_DIN_MODE, mode);
- val |= FIELD_PREP(SPIFC_A1_USER_DIN_BYTES, size);
+ FIELD_MODIFY(SPIFC_A1_USER_DIN_MODE, &val, mode);
+ FIELD_MODIFY(SPIFC_A1_USER_DIN_BYTES, &val, size);
writel(val, spifc->base + SPIFC_A1_USER_CTRL3_REG);
ret = amlogic_spifc_a1_request(spifc, true);
--
2.34.1
More information about the linux-amlogic
mailing list