[PATCH 7/8] dt-bindings: interrupt-controller: Add Amlogic Meson GPIO interrupt controller binding

Rob Herring robh at kernel.org
Wed Jan 25 08:46:22 PST 2023


On Tue, Jan 24, 2023 at 1:04 AM Heiner Kallweit <hkallweit1 at gmail.com> wrote:
>
> On 24.01.2023 02:22, Rob Herring wrote:
> >
> > On Mon, 23 Jan 2023 22:30:08 +0100, Heiner Kallweit wrote:
> >> Add Amlogic Meson GPIO interrupt controller binding.
> >> Tested with make targets dt_binding_check and dtbs_check.
> >>
> >> Signed-off-by: Heiner Kallweit <hkallweit1 at gmail.com>
> >> ---
> >>  .../amlogic,meson-gpio-intc.txt               | 38 ----------
> >>  .../amlogic,meson-gpio-intc.yaml              | 72 +++++++++++++++++++
> >>  2 files changed, 72 insertions(+), 38 deletions(-)
> >>  delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
> >>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml
> >>
> >
> > Running 'make dtbs_check' with the schema in this patch gives the
> > following warnings. Consider if they are expected or the schema is
> > incorrect. These may not be new warnings.
> >
>
> Patch 4 of the series fixes these warnings.

Then you can ignore them.

You did change the binding somewhat and that should be detailed in the
commit message. Granted, the original details on 'compatible' seem to
have a typo and are ambiguous on the order of entries.

> Did you apply the full series?

No, because patchwork doesn't get the full series nor do I see the
full thread when reviewing these bot emails before sending them. If I
see a conversion and warnings that look like the schema should be
fixed rather than the dts files, then you get this email. Though on
further review, dropping 'amlogic,meson-gpio-intc' seems fine given it
is often in the wrong spot (it should be last as it is least
specific).

Rob



More information about the linux-amlogic mailing list