[PATCH net-next] net: phy: meson-gxl: support more G12A-internal PHY versions
Anand Moon
linux.amoon at gmail.com
Sun Jan 15 11:42:02 PST 2023
Hi Heiner,
On Mon, 16 Jan 2023 at 00:14, Neil Armstrong <neil.armstrong at linaro.org> wrote:
>
> Hi Heiner,
>
> Le 15/01/2023 à 18:09, Heiner Kallweit a écrit :
> > On 15.01.2023 17:57, Andrew Lunn wrote:
> >> On Sun, Jan 15, 2023 at 04:19:37PM +0100, Heiner Kallweit wrote:
> >>> On my SC2-based system the genphy driver was used because the PHY
> >>> identifies as 0x01803300. It works normal with the meson g12a
> >>> driver after this change.
> >>> Switch to PHY_ID_MATCH_MODEL to cover the different sub-versions.
> >>
> >> Hi Heiner
> >>
> >> Are there any datasheets for these devices? Anything which documents
> >> the lower nibble really is a revision?
> >>
> >> I'm just trying to avoid future problems where we find it is actually
> >> a different PHY, needs its own MATCH_EXACT entry, and then we find we
> >> break devices using 0x01803302 which we had no idea exists, but got
> >> covered by this change.
> >>
> > The SC2 platform inherited a lot from G12A, therefore it's plausible
> > that it's the same PHY. Also the vendor driver for SC2 gives a hint
> > as it has the following compatible for the PHY:
> >
> > compatible = "ethernet-phy-id0180.3301", "ethernet-phy-ieee802.3-c22";
> >
> > But you're right, I can't say for sure as I don't have the datasheets.
>
> On G12A (& GXL), the PHY ID is set in the MDIO MUX registers,
> please see:
> https://elixir.bootlin.com/linux/latest/source/drivers/net/mdio/mdio-mux-meson-g12a.c#L36
>
> So you should either add support for the PHY mux in SC2 or check
> what is in the ETH_PHY_CNTL0 register.
>
I you want to read the ethernet id, we can use the following tool
[0] https://github.com/wkz/mdio-tools
om my odroid-n2 it show
alarm at odroid-n2:~/mdio-tools$ sudo mdio mdio_mux-0.0
DEV PHY-ID LINK
0x00 0x001cc916 down
0x01 0x001cc916 up
-Anand
> Neil
>
> >
> >> Andrew
> >
> > Heiner
>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
More information about the linux-amlogic
mailing list