[PATCH v3] af_rxrpc: Keep rxrpc_call pointers in a hashtable

[Tim Smith]

On Thursday 27 February 2014 12:41:59 David Howells wrote:
> Tim Smith <tim at electronghost.co.uk> wrote:
> > +	key = (unsigned long)localptr;
> > +	key += epoch;
> > +	key += service_id;
> > +	key += call_id;
> > +	key += (cid & RXRPC_CIDMASK) >> RXRPC_CIDSHIFT;
> > +	key += cid & RXRPC_CHANNELMASK;
> > +	key += clientflag;
> > +	key += proto;
> 
> It seems that all these need casting to get rid of the __be attribute to
> keep sparse happy.

I was coming to that conclusion. First time I've seen one of those.

> I wonder if it makes sense to pass the result through ntohl() after adding
> everything up (perhaps add localptr after that).

Well the thing is, I don't actually care whether I'm adding 0x00000001 or 
0x01000000. I don't even care if it (key) overflows. Is there a good reason to 
take the potential hit of an endian swap?

-- 
Tim Smith <tim at electronghost.co.uk>
Things are much more like they used to be than they are now.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-afs/attachments/20140227/2ba8a6b2/attachment.sig>