[PATCH v3] af_rxrpc: Keep rxrpc_call pointers in a hashtable

David Howells dhowells at redhat.com
Thu Feb 27 07:41:59 EST 2014


Tim Smith <tim at electronghost.co.uk> wrote:

> +	key = (unsigned long)localptr;
> +	key += epoch;
> +	key += service_id;
> +	key += call_id;
> +	key += (cid & RXRPC_CIDMASK) >> RXRPC_CIDSHIFT;
> +	key += cid & RXRPC_CHANNELMASK;
> +	key += clientflag;
> +	key += proto;

It seems that all these need casting to get rid of the __be attribute to keep
sparse happy.

I wonder if it makes sense to pass the result through ntohl() after adding
everything up (perhaps add localptr after that).

David



More information about the linux-afs mailing list