[Freeassociation-devel] libical fix recurrence not excluded when it should be

[dothebart]

having a look at the code you remove (since its just used in that place)  

this function:  

struct icaltimetype icalproperty_get_exdate(const icalproperty* prop){
 icalerror_check_arg( (prop!=0),"prop");
#ifndef _MSC_VER
 /*
 * Code by dirk   objectpark.net:
 * Set the time zone manually. I am really puzzled that 
 * it doesnot work automatically like in the other functions 
 * like icalproperty_get_dtstart().
 */
 struct icaltimetype itt =
 icalvalue_get_datetime(icalproperty_get_value(prop));
 icalparameter* param = icalproperty_get_first_parameter(prop,
 ICAL_TZID_PARAMETER);
 if (param) {
 const icaltimezone *zone =
 icaltimezone_get_builtin_timezone(icalparameter_get_tzid(param));
 icaltime_set_timezone(&itt, zone);
 }
 return itt;
#else
 return icalvalue_get_datetime(icalproperty_get_value(prop));
#endif
}
  

seems to live in an autogenerated file; its not in SVN? I also wasn't able to
find that comment or the functionname anywhere else...  

If that code causes the bug (since Gren basicaly did the fallback to the no
more used #else case..) was that code a workaround for that big timezone bug?
 

If yes, should we remove the function and call it directly like Grens Patch
suggests? or should we call this function and remove the #if?  

Allen, Patrick, Art, some comment on this?  

   
>  Do Aug 06 2009 10:15:46 EDT von  "Gren Elliot" <gren.elliot at scalix.com> 
>Betreff: libical fix recurrence not excluded when it should be
>
>        
>    Hi dothebart, 
> 
> Here is the second promised patch, plus an example program demonstrating
>the issue.
> The issue is that "icalproperty_recurrence_is_excluded" does not take into
>account any timezone associated with EXDATEs being tested.
> 
> I compiled the example program on Fedora 10 (with libical-0.43-4.fc10
>installed) using : 
> gcc -g -o recurrenceNotExcluded -Wstrict-prototypes -I/usr/include/libical
>-lical recurrenceNotExcluded.c
> 
> Running the binary : 
> ./recurrenceNotExcluded
> FAIL!!! 20080818T180000Z NOT excluded even though it matches
> EXDATE;TZID=/mozilla.org/20071231_1/Europe/London:20080818T190000
> 
> Thanks and regards, 
> Gren. 
>
>
>        
>  
>
>   (, 0 bytes)  Herunterladen
>  
>
>  
>
>   (, 0 bytes)  Herunterladen
>  
>
>  
>
>  
>
>  

  

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/libical-devel/attachments/20090807/535aa5d7/attachment.html>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: recurrenceNotExcluded.patch
URL: <http://lists.infradead.org/pipermail/libical-devel/attachments/20090807/535aa5d7/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: recurrenceNotExcluded.c
URL: <http://lists.infradead.org/pipermail/libical-devel/attachments/20090807/535aa5d7/attachment.c>