<html><body>
<p>having a look at the code you remove (since its just used in that place)</p>
<p>this function:</p>
<p>struct icaltimetype icalproperty_get_exdate(const icalproperty* prop){<br /> icalerror_check_arg( (prop!=0),"prop");<br />#ifndef _MSC_VER<br /> /*<br /> * Code by dirk objectpark.net:<br /> * Set the time zone manually. I am really puzzled that <br /> * it doesnot work automatically like in the other functions <br /> * like icalproperty_get_dtstart().<br /> */<br /> struct icaltimetype itt =<br /> icalvalue_get_datetime(icalproperty_get_value(prop));<br /> icalparameter* param = icalproperty_get_first_parameter(prop,<br /> ICAL_TZID_PARAMETER);<br /> if (param) {<br /> const icaltimezone *zone =<br /> icaltimezone_get_builtin_timezone(icalparameter_get_tzid(param));<br /> icaltime_set_timezone(&itt, zone);<br /> }<br /> return itt;<br />#else<br /> return icalvalue_get_datetime(icalproperty_get_value(prop));<br />#endif<br />}<br /></p>
<p>seems to live in an autogenerated file; its not in SVN? I also wasn't able to find that comment or the functionname anywhere else...</p>
<p>If that code causes the bug (since Gren basicaly did the fallback to the no more used #else case..) was that code a workaround for that big timezone bug?</p>
<p>If yes, should we remove the function and call it directly like Grens Patch suggests? or should we call this function and remove the #if?</p>
<p>Allen, Patrick, Art, some comment on this?</p>
<p> </p>
<blockquote>
<div class="message_header"><span>Do Aug 06 2009 10:15:46 EDT</span> <span>von "Gren Elliot" <gren.elliot@scalix.com> </span> <span class="message_subject">Betreff: libical fix recurrence not excluded when it should be</span></div>
<div class="message_content">
<table border="0" width="100%" bgcolor="#ffffff">
<tbody>
<tr>
<td>
<div class="moz-text-flowed" style="font-family: -moz-fixed; font-size: 13px;" lang="x-western">Hi dothebart, <br /> <br /> Here is the second promised patch, plus an example program demonstrating the issue.<br /> The issue is that "icalproperty_recurrence_is_excluded" does not take into account any timezone associated with EXDATEs being tested.<br /> <br /> I compiled the example program on Fedora 10 (with libical-0.43-4.fc10 installed) using : <br /> gcc -g -o recurrenceNotExcluded -Wstrict-prototypes -I/usr/include/libical -lical recurrenceNotExcluded.c<br /> <br /> Running the binary : <br /> ./recurrenceNotExcluded<br /> FAIL!!! 20080818T180000Z NOT excluded even though it matches<br /> EXDATE;TZID=/mozilla.org/20071231_1/Europe/London:20080818T190000<br /> <br /> Thanks and regards, <br /> Gren. <br /></div>
</td>
</tr>
</tbody>
</table>
<br /><br />
<div class="display_inline_attachment"><img src="display_mime_icon?type=" border="0" alt="" align="middle" /> (, 0 bytes) <a href="mimepart_download/0">Herunterladen</a><br />
<div class="display_inline_attachment_body"></div>
</div>
<div class="display_inline_attachment"><img src="display_mime_icon?type=" border="0" alt="" align="middle" /> (, 0 bytes) <a href="mimepart_download/0">Herunterladen</a><br />
<div class="display_inline_attachment_body"></div>
</div>
</div>
</blockquote>
<p> </p>
</body></html>