[LEDE-DEV] [RFC] [PULL REQUEST] rt2x00 patches from OpenWrt.org

Daniel Golle daniel at makrotopia.org
Fri Jan 13 07:46:30 PST 2017

Hi Kalle,

On Fri, Jan 13, 2017 at 12:46:56PM +0200, Kalle Valo wrote:
> Daniel Golle <daniel at makrotopia.org> writes:
> > ...
> > Please review and comment, so we can get those patches merged!
> No pull requests, please. Instead send these as patches, easier to
> review and actually also easier for me to merge.

The advantage of pull requests is that author information can be
preserved more easily. Running git format-patch results in most patches
having wrong SMTP sender information due to the assumption that the
patch author is the same person also submitting the patch.
So in practise, this would either require changing the From: (and thus
Author) to myself or having most mails eaten by anti-spam measures due
to non-matching SPF which prohibits my SMTP to send mail on behalf of
the original authors of the patches.

How do you suggest to handle this situation?



More information about the Lede-dev mailing list