[LEDE-DEV] [PATCH v2 09/14] rt2x00: rt2x00pci: set PCI MWI only if supported

Daniel Golle daniel at makrotopia.org
Tue Jan 17 03:20:04 PST 2017


Hi John,

On Tue, Jan 17, 2017 at 08:34:44AM +0100, John Crispin wrote:
> here is the original thread related to this patch
> 
> http://rt2x00.serialmonkey.com/pipermail/users_rt2x00.serialmonkey.com/2012-November/012227.html

nah, that was me apparently trying to submit this upstream once before
a couple of years ago.
the patch was added by claudio in
https://dev.openwrt.org/changeset/21850
supposedly to fix a build error on kernel 2.6.30
https://dev.openwrt.org/ticket/6538

as the config symbol is undefined in current kernels, I reckon we just
always had MWI disabled from some point on...
Back then RT2X00_LIB_SOC and RT2X00_LIB_MMIO still depended on
RT2X00_LIB_PCI which is no longer the case, ie. everything should be
fine without that ancient even on non-PCI platforms (on which the build
error initially triggered -- rt305x doesn't have PCI at all)
So let's remove it and find out :)


Cheers


Daniel

> 
> 	John
> 
> > Cheers
> > 
> > 
> > Daniel
> > 
> >>
> >> Stanislaw



More information about the Lede-dev mailing list