[PATCH 2/6] bss_coloring: add the code required to generate the CCA IE

[Jouni Malinen]

On Wed, Sep 08, 2021 at 05:18:51PM +0800, Ryder Lee wrote:
> Signed-off-by: Lorenzo Bianconi <lorenzo at kernel.org>
> diff --git a/src/ap/beacon.c b/src/ap/beacon.c
> @@ -578,11 +578,17 @@ static u8 * hostapd_gen_probe_resp(struct hostapd_data *hapd,
>  #ifdef CONFIG_IEEE80211AX
>  	if (hapd->iconf->ieee80211ax && !hapd->conf->disable_11ax) {
> +		u8 *cca_pos;
> +
>  		pos = hostapd_eid_he_capab(hapd, pos, IEEE80211_MODE_AP);
>  		pos = hostapd_eid_he_operation(hapd, pos);
>  		pos = hostapd_eid_spatial_reuse(hapd, pos);
>  		pos = hostapd_eid_he_mu_edca_parameter_set(hapd, pos);
>  		pos = hostapd_eid_he_6ghz_band_cap(hapd, pos);
> +		cca_pos = hostapd_eid_cca(hapd, pos);

The BSS Color Change Announcement element is supposed to be between the
HE Operation and the Spatial Reuse Parameter Set elements, i.e., a
couple of lines above here..

> @@ -1567,12 +1573,18 @@ int ieee802_11_build_ap_params(struct hostapd_data *hapd,
>  #ifdef CONFIG_IEEE80211AX
>  	if (hapd->iconf->ieee80211ax && !hapd->conf->disable_11ax) {
> +		u8 *cca_pos;
> +
>  		tailpos = hostapd_eid_he_capab(hapd, tailpos,
>  					       IEEE80211_MODE_AP);
>  		tailpos = hostapd_eid_he_operation(hapd, tailpos);
>  		tailpos = hostapd_eid_spatial_reuse(hapd, tailpos);
>  		tailpos = hostapd_eid_he_mu_edca_parameter_set(hapd, tailpos);
>  		tailpos = hostapd_eid_he_6ghz_band_cap(hapd, tailpos);
> +		cca_pos = hostapd_eid_cca(hapd, tailpos);

Same here.

What about the (Re)Association Response frames? Should we add the BSS
Color Change Announcement element to them as well?
 
-- 
Jouni Malinen                                            PGP id EFC895FA