[PATCH v2] supplicant: Allow custom probe and assoc req ie.

Jouni Malinen j at w1.fi
Sun Apr 17 09:21:11 PDT 2016


On Sat, Apr 09, 2016 at 08:33:00AM -0700, Ben Greear wrote:
> It would be a bit of a hack to the parsing logic, most likely, but what
> about:
> 
> vendor_elemen_default [index] [value]
> 
> For instance:
> 
> vendor_element_default 14 0011223344abddeeff
> 
> The config-file help comments could do the explanation of what each index meant,
> and we figure most users never need to care, but the ones that do will
> have the needed control.

I don't think I would like to add this type of completely different type
of configuration file parameter. I guess that could be modified to be
vendor_element_default=14:0011223344abddeeff to make it look a bit more
like existing global parameters. Still, this would not really behave the
same and I'm not sure what would be stored in wpa_config_write_global()
for such values.

> >Maybe it would easiest to just add the two configuration parameters that
> >you had in the patch and update the documentation to state that they are
> >initial values used at interface start and changes during operation need
> >to be done using the VENDOR_ELEM* commands. This is neither generic nor
> >very clean, but at least the amount of code to maintain for this would
> >be pretty minimal.
> 
> This is fine with me as well.

At least for now, I think this is going to be safer approach..
wpa_config_write_global() behavior is clear and the runtime changes on
these two parameters and VENDOR_ELEM* commands are independent.
 
-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list