[PATCH v2] supplicant: Allow custom probe and assoc req ie.

Ben Greear greearb at candelatech.com
Tue Apr 19 07:06:49 PDT 2016

On 04/17/2016 09:21 AM, Jouni Malinen wrote:
> On Sat, Apr 09, 2016 at 08:33:00AM -0700, Ben Greear wrote:

>>> Maybe it would easiest to just add the two configuration parameters that
>>> you had in the patch and update the documentation to state that they are
>>> initial values used at interface start and changes during operation need
>>> to be done using the VENDOR_ELEM* commands. This is neither generic nor
>>> very clean, but at least the amount of code to maintain for this would
>>> be pretty minimal.
>> This is fine with me as well.
> At least for now, I think this is going to be safer approach..
> wpa_config_write_global() behavior is clear and the runtime changes on
> these two parameters and VENDOR_ELEM* commands are independent.

The "vendor_elem" array is in the wpa_s struct, but the config logic
deals with "struct wpa_config", which has no way to reference wpa_s as
far as I can tell.

Any opinion on moving wpa_s->vendor_elem to the wpa_config struct?

Or, maybe add a back-pointer from wpa_config to the wpa_s?


Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

More information about the Hostap mailing list