[PATCH v2] supplicant: Allow custom probe and assoc req ie.

[Ben Greear]

On 04/09/2016 01:03 AM, Jouni Malinen wrote:
> On Fri, Apr 08, 2016 at 02:11:36PM -0700, Ben Greear wrote:
>> So, I will try to code up a patch to set the VENDOR_ELEM values using
>> the .conf file if you will accept the patch.
>
> I might.. I've been trying to think what would be a nice way of doing
> this as a general solution, but could not really find one. In some
> sense, I'd like to support all VENDOR_ELEM values in a manner that would
> allow easy extension of this similarly to how the VENDOR_ELEM_* commands
> themselves do. However, the current configuration parsing logic does not
> really make that very convenient (e.g., having "vendor_elem_default_0"
> .. "vendor_elem_default_14" as separately defined parameters can be
> hundred or more lines of code..).

It would be a bit of a hack to the parsing logic, most likely, but what
about:

vendor_elemen_default [index] [value]

For instance:

vendor_element_default 14 0011223344abddeeff

The config-file help comments could do the explanation of what each index meant,
and we figure most users never need to care, but the ones that do will
have the needed control.

>
> Maybe it would easiest to just add the two configuration parameters that
> you had in the patch and update the documentation to state that they are
> initial values used at interface start and changes during operation need
> to be done using the VENDOR_ELEM* commands. This is neither generic nor
> very clean, but at least the amount of code to maintain for this would
> be pretty minimal.

This is fine with me as well.

Thanks,
Ben


-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com