[PATCH] P2P: ignore neg_req with the last used dialog_token

Jouni Malinen j
Mon Mar 5 10:04:59 PST 2012

On Mon, Mar 05, 2012 at 02:09:47PM +0200, Eliad Peller wrote:
> If for some reason we get duplicate negotiation request,
> the supplicant will generate 2 different responses
> (with different SSIDs) with the same dialog token.
> The remote peer will confirm one of them, but it will
> probably be the wrong one (the first it received,
> whlie we keep track of the last one).
> Workaround it but ignoring negotiation requests with
> the last used dialog_token.

How do you know that the peer does not use the same dialog token again
for the next GO Negotiation? Please keep in mind that the peer may be
using different implementation.. In addition, there could be cases where
our GO Negotiation Response is lost and peer tries to send GO
Negotiation Request again. As such, I'm not sure this is really a
suitable way of working around this.

Furthermore, I'm not completely sure what exactly you are trying to work
around. The changing SSID? Didn't commit
4458d91554cce6c8a78916701c2701162cbbfad1 already take care of that?

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list