Format of options file

[Colin Law]

On 5 March 2018 at 12:02, Ralph Corderoy <ralph at inputplus.co.uk> wrote:
> Hi Colin,
>
>> > > ') - using defaultalue for --ffmpeg-loglevel ('info
>> >
>> > That line above seems to be overprinting the «')» at the start of
>> > the line suggesting there's an ASCII CR, carriage return, after the
>> > `info' as if a Unix system was reading a POSIX text file of lines
>> > ending in ASCII LF, linefeed, but being fed a DOS one with CR LF
>> > pairs.
>>
>> Are we certain that the problem has been correctly analysed?
>
> Yes, I did.  :-)
>
>> The line shown above appears to have a CR after info and before the
>> quote sign, which would not be valid on either system.
>
> Because the value is «info\r» and it's being printed surrounded by
> «('...')».
>
>     WARNING: invalid value for --ffmpeg-loglevel ('$opt->{ffmpegloglevel}') - using default\n
>
> becomes
>
>     WARNING: invalid value for --ffmpeg-loglevel ('info
>     ') - using default
>
> becomes
>
>     ') - using defaultalue for --ffmpeg-loglevel ('info

Yes, I agree.  For anyone who knows the code it should not be
difficult to ignore CR characters after the text. I expect it is
already ignoring white space after it.  Any patch takes time to work
out and to test though.

Colin

>
> --
> Cheers, Ralph.
> https://plus.google.com/+RalphCorderoy
>
> _______________________________________________
> get_iplayer mailing list
> get_iplayer at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/get_iplayer