[PATCH 3/8] clk: composite: return ERR_PTR on registration failure

Ahmad Fatoum a.fatoum at pengutronix.de
Mon Aug 31 12:35:50 PDT 2026


From: Ahmad Fatoum <a.fatoum at barebox.org>

clk_register_composite() returns 0 instead of ERR_PTR(ret) on error, so
callers checking IS_ERR() see a failed registration as success.

Fixes: 9eb9f0004347 ("CLK: Add support for composite clock from Linux kernel")
Reported-by: Claude:opus-4.6
Signed-off-by: Ahmad Fatoum <a.fatoum at barebox.org>
---
 drivers/clk/clk-composite.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk-composite.c b/drivers/clk/clk-composite.c
index a23e828f587f..4cf3a91a63b4 100644
--- a/drivers/clk/clk-composite.c
+++ b/drivers/clk/clk-composite.c
@@ -239,7 +239,7 @@ struct clk *clk_register_composite(const char *name,
 
 err:
 	kfree(composite);
-	return 0;
+	return ERR_PTR(ret);
 }
 
 struct clk_hw *clk_hw_register_composite(struct device *dev,
-- 
2.47.3




More information about the barebox mailing list