[PATCH v3 1/4] ARM: novena: Add Kosagi Novena board
Marco Felsch
m.felsch at pengutronix.de
Tue Jan 31 01:45:14 PST 2023
On 23-01-31, John Watts wrote:
> On Mon, Jan 30, 2023 at 09:13:08PM +0100, Marco Felsch wrote:
> > > +#define STACK_TOP (MX6_OCRAM_BASE_ADDR + MX6_OCRAM_MAX_SIZE)
> > > +
> > > +extern char __dtb_imx6q_novena_start[];
> >
> > Can we use compressed device-tree's instead? For this feature you only
> > need to rename this variable to: __dtb_z_imx6q_novena_start[] and select
> > 'ARM_USE_COMPRESSED_DTB' within the Kconfig.
> >
> > An example can be found here:
> > - arch/arm/boards/zii-imx6q-rdu2/lowlevel.c
> > - arch/arm/mach-imx/Kconfig
> >
> > Sorry for not recognize it the first time.
>
> Sure!
>
> > > + pr_err("Unsupported boot source %i instance %i\n",
> > > + bootsrc, bootinstance);
> >
> > Nit: Please align it correctly.
>
> Just a single tab?
Alligend with the opening parenthesis so like this:
| pr_err("Unsupported boot source %i instance %i\n",
| bootsrc, bootinstance);
Regards,
Marco
More information about the barebox
mailing list