[PATCH v3 3/4] ARM: novena: Read Ethernet MAC address from EEPROM

Marco Felsch m.felsch at pengutronix.de
Tue Jan 31 01:29:53 PST 2023


On 23-01-31, John Watts wrote:
> On Mon, Jan 30, 2023 at 09:04:43PM +0100, Marco Felsch wrote:
> > Hi John,
> > 
> > thanks for the patch.
> 
> Thanks for the review as always :)
> 
> > This will trigger a double free since you're use of an unconditional
> > free() during probe().
> 
> It returns NULL, so probe will do a no-op.

Arg.. you're right. I shouldn't review something that late ^^

Regards,
  Marco

> > Regards,
> >   Marco
> 
> John.
> 



More information about the barebox mailing list